Skip to content

feat: add support for deployment labels and annotations#70

Open
dadangnh wants to merge 4 commits intoCircleCI-Public:mainfrom
dadangnh:feat/add-support-for-deployment-labels-and-annotations
Open

feat: add support for deployment labels and annotations#70
dadangnh wants to merge 4 commits intoCircleCI-Public:mainfrom
dadangnh:feat/add-support-for-deployment-labels-and-annotations

Conversation

@dadangnh
Copy link

⚙️ Issue

Ticket/s: -

⚙️ Change

Add ability to configure custom annotations and labels at the Deployment level through Helm values. This gives users more flexibility in managing and identifying their container-agent deployments.

Change Type: new feature

  • Add deploymentAnnotations and deploymentLabels fields to values.yaml
  • Update deployment.yaml to apply these values when defined
  • Both fields default to empty maps for backward compatibility

AC:

Fix

Tests

  • Tests for new feature and update for changes
  • Linting passes and/or formatting matches the standard of the repo

🗒️ Documentation

  • Updated related documentation (if applicable).
  • Updated Change log (if exists)

@dadangnh dadangnh requested a review from a team as a code owner December 30, 2024 05:33
@dadangnh
Copy link
Author

Hi @christian-stephen @Stuart133 , kindly review this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant